linux-kernel - Re: [PATCH v2 04/11] platform/x86:intel/pmc: Convert index variables to be unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7880c5cb-3b32-0956-30ce-b25fe537de07@linux.intel.com>
Date: Thu, 29 Aug 2024 13:54:22 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Xi Pardee <xi.pardee@...ux.intel.com>
cc: irenic.rajneesh@...il.com, david.e.box@...ux.intel.com, 
    Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 04/11] platform/x86:intel/pmc: Convert index variables
 to be unsigned

On Wed, 28 Aug 2024, Xi Pardee wrote:

> Convert the index variables type to be unsigned to avoid confusion
> and error.
> 
> Signed-off-by: Xi Pardee <xi.pardee@...ux.intel.com>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.

> ---
>  drivers/platform/x86/intel/pmc/core.c            | 5 +++--
>  drivers/platform/x86/intel/pmc/core.h            | 2 +-
>  drivers/platform/x86/intel/pmc/ssram_telemetry.c | 2 +-
>  3 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
> index 630ce2087552..8984041f35f4 100644
> --- a/drivers/platform/x86/intel/pmc/core.c
> +++ b/drivers/platform/x86/intel/pmc/core.c
> @@ -1716,7 +1716,8 @@ static int pmc_core_get_lpm_req(struct pmc_dev *pmcdev, struct pmc *pmc)
>  
>  int pmc_core_ssram_get_lpm_reqs(struct pmc_dev *pmcdev)
>  {
> -	int ret, i;
> +	unsigned int i;
> +	int ret;
>  
>  	if (!pmcdev->ssram_pcidev)
>  		return -ENODEV;
> @@ -1743,7 +1744,7 @@ const struct pmc_reg_map *pmc_core_find_regmap(struct pmc_info *list, u16 devid)
>  }
>  
>  int pmc_core_pmc_add(struct pmc_dev *pmcdev, u64 pwrm_base,
> -		     const struct pmc_reg_map *reg_map, int pmc_index)
> +		     const struct pmc_reg_map *reg_map, unsigned int pmc_index)
>  {
>  	struct pmc *pmc = pmcdev->pmcs[pmc_index];
>  
> diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
> index 6763e59180a4..5af1d41a83f7 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -606,7 +606,7 @@ extern void pmc_core_set_device_d3(unsigned int device);
>  extern int pmc_core_ssram_init(struct pmc_dev *pmcdev, int func);
>  extern const struct pmc_reg_map *pmc_core_find_regmap(struct pmc_info *list, u16 devid);
>  extern int pmc_core_pmc_add(struct pmc_dev *pmcdev, u64 pwrm_base,
> -			    const struct pmc_reg_map *reg_map, int pmc_index);
> +			    const struct pmc_reg_map *reg_map, unsigned int pmc_index);
>  
>  int spt_core_init(struct pmc_dev *pmcdev);
>  int cnp_core_init(struct pmc_dev *pmcdev);
> diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
> index 0a2bfca5ff41..4b21d9cf310a 100644
> --- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c
> +++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c
> @@ -75,7 +75,7 @@ static inline u64 get_base(void __iomem *addr, u32 offset)
>  }
>  
>  static int
> -pmc_core_ssram_get_pmc(struct pmc_dev *pmcdev, int pmc_idx, u32 offset)
> +pmc_core_ssram_get_pmc(struct pmc_dev *pmcdev, unsigned int pmc_idx, u32 offset)
>  {
>  	struct pci_dev *ssram_pcidev = pmcdev->ssram_pcidev;
>  	void __iomem __free(pmc_core_iounmap) *tmp_ssram = NULL;
>