linux-kernel - Re: [PATCH v2 05/11] platform/x86:intel/pmc: Remove unneeded h file inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bda80eb-c0b8-c9c7-5c18-bb06701a69cb@linux.intel.com>
Date: Thu, 29 Aug 2024 14:02:19 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Xi Pardee <xi.pardee@...ux.intel.com>
cc: irenic.rajneesh@...il.com, david.e.box@...ux.intel.com, 
    Hans de Goede <hdegoede@...hat.com>, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 05/11] platform/x86:intel/pmc: Remove unneeded h file
 inclusion

On Wed, 28 Aug 2024, Xi Pardee wrote:

In the subject:

h file -> header

> telemetry.h header file is not needed in arl.c or mtl.c. Remove
> them to avoid confusion.

I'd also note this is cross directory/driver include, so perhaps something 
along these lines:

telemetry.h from PMT is not needed in arl.c or mtl.c so remove
the cross-driver include.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.

> Signed-off-by: Xi Pardee <xi.pardee@...ux.intel.com>
> ---
>  drivers/platform/x86/intel/pmc/arl.c | 1 -
>  drivers/platform/x86/intel/pmc/mtl.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c
> index 870da98ceb41..0460715c58f4 100644
> --- a/drivers/platform/x86/intel/pmc/arl.c
> +++ b/drivers/platform/x86/intel/pmc/arl.c
> @@ -10,7 +10,6 @@
>  
>  #include <linux/pci.h>
>  #include "core.h"
> -#include "../pmt/telemetry.h"
>  
>  /* PMC SSRAM PMT Telemetry GUID */
>  #define IOEP_LPM_REQ_GUID	0x5077612
> diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c
> index 908b5f8bb6e5..e7f5b650902d 100644
> --- a/drivers/platform/x86/intel/pmc/mtl.c
> +++ b/drivers/platform/x86/intel/pmc/mtl.c
> @@ -10,7 +10,6 @@
>  
>  #include <linux/pci.h>
>  #include "core.h"
> -#include "../pmt/telemetry.h"
>  
>  /* PMC SSRAM PMT Telemetry GUIDS */
>  #define SOCP_LPM_REQ_GUID	0x2625030
>