linux-kernel - Re: [PATCH] selftests/arm64: Fix build warnings for abi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3699c056-693b-4313-a750-2e777b48ed46@sirena.org.uk>
Date: Thu, 29 Aug 2024 12:02:21 +0100
From: Mark Brown <broonie@...nel.org>
To: Dev Jain <dev.jain@....com>
Cc: shuah@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, Catalin.Marinas@....com,
	will@...nel.org, ryan.roberts@....com, Anshuman.Khandual@....com,
	aneesh.kumar@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests/arm64: Fix build warnings for abi

On Thu, Aug 29, 2024 at 11:55:33AM +0530, Dev Jain wrote:
> On 8/28/24 16:10, Mark Brown wrote:

> > > -		ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
> > > +		ksft_exit_fail_perror("raise(SIGSTOP)");

> > The idea with these is to include the error code as well so adding the
> > %s would be better.

> ksft_exit_fail_perror() can do that thing for us.

Oh, sorry - I missed that it was changing to _perror() as well as
removing the argument.  Yes, that's fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)