linux-kernel - Re: [PATCH v1 2/9] fs/fuse: add FUSE_OWNER_UID_GID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegsVY97_5mHSc06mSw79FehFWtoXT=hhTUK_E-Yhr7OAuQ@mail.gmail.com>
Date: Thu, 29 Aug 2024 14:29:59 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: Christian Brauner <brauner@...nel.org>
Cc: Aleksandr Mikhalitsyn <aleksandr.mikhalitsyn@...onical.com>, mszeredi@...hat.com, 
	stgraber@...raber.org, linux-fsdevel@...r.kernel.org, 
	Seth Forshee <sforshee@...nel.org>, Amir Goldstein <amir73il@...il.com>, 
	Bernd Schubert <bschubert@....com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/9] fs/fuse: add FUSE_OWNER_UID_GID_EXT extension

On Thu, 29 Aug 2024 at 14:08, Christian Brauner <brauner@...nel.org> wrote:

> Fwiw, that's what the patchset is doing. It's only supported if the
> server sets "default_permissions".

My specific issue is with FUSE_EXT_OWNER_UID_GID, which I think is
unnecessary.  Just fill the header with the mapped uid/gid values,
which most servers already use for creating the file with the correct
st_uid/st_gid and not for checking permission.  When the mapped values
are unavailable, set the uid/gid in the header -1.  Should be better
than sending nonsense values to userspace, no?

Thanks,
Miklos