linux-kernel - Re: [PATCH net-next v2 02/12] net: skb: add pskb_network_may_pull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06ff49c5-10b0-42dd-946c-388f5cc3a1e1@intel.com>
Date: Fri, 30 Aug 2024 16:45:00 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Menglong Dong <menglong8.dong@...il.com>
CC: <idosch@...dia.com>, <kuba@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <dsahern@...nel.org>,
	<dongml2@...natelecom.cn>, <amcohen@...dia.com>, <gnault@...hat.com>,
	<bpoirier@...dia.com>, <b.galvani@...il.com>, <razor@...ckwall.org>,
	<petrm@...dia.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 02/12] net: skb: add
 pskb_network_may_pull_reason() helper

From: Menglong Dong <menglong8.dong@...il.com>
Date: Fri, 30 Aug 2024 09:59:51 +0800

> Introduce the function pskb_network_may_pull_reason() and make
> pskb_network_may_pull() a simple inline call to it. The drop reasons of
> it just come from pskb_may_pull_reason.

No object code changes I guess? Have you checked it via
scripts/bloat-o-meter?

> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> ---
>  include/linux/skbuff.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index cf8f6ce06742..fe6f97b550fc 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -3114,9 +3114,15 @@ static inline int skb_inner_network_offset(const struct sk_buff *skb)
>  	return skb_inner_network_header(skb) - skb->data;
>  }
>  
> +static inline enum skb_drop_reason
> +pskb_network_may_pull_reason(struct sk_buff *skb, unsigned int len)
> +{
> +	return pskb_may_pull_reason(skb, skb_network_offset(skb) + len);
> +}
> +
>  static inline int pskb_network_may_pull(struct sk_buff *skb, unsigned int len)
>  {
> -	return pskb_may_pull(skb, skb_network_offset(skb) + len);
> +	return pskb_network_may_pull_reason(skb, len) == SKB_NOT_DROPPED_YET;
>  }
>  
>  /*

Thanks,
Olek