linux-kernel - Re: [PATCH net-next v2 01/12] net: vxlan: add vxlan to the drop reason subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32b49d2d-fac7-47cb-aa78-c21e8bd2f479@intel.com>
Date: Fri, 30 Aug 2024 16:42:38 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Menglong Dong <menglong8.dong@...il.com>
CC: <idosch@...dia.com>, <kuba@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <dsahern@...nel.org>,
	<dongml2@...natelecom.cn>, <amcohen@...dia.com>, <gnault@...hat.com>,
	<bpoirier@...dia.com>, <b.galvani@...il.com>, <razor@...ckwall.org>,
	<petrm@...dia.com>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 01/12] net: vxlan: add vxlan to the drop
 reason subsystem

From: Menglong Dong <menglong8.dong@...il.com>
Date: Fri, 30 Aug 2024 09:59:50 +0800

> In this commit, we introduce the SKB_DROP_REASON_SUBSYS_VXLAN to make the
> vxlan support skb drop reasons.
> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> ---
>  drivers/net/vxlan/drop.h          | 25 +++++++++++++++++++++++++
>  drivers/net/vxlan/vxlan_core.c    | 15 +++++++++++++++
>  drivers/net/vxlan/vxlan_private.h |  1 +
>  include/net/dropreason.h          |  6 ++++++
>  4 files changed, 47 insertions(+)
>  create mode 100644 drivers/net/vxlan/drop.h
> 
> diff --git a/drivers/net/vxlan/drop.h b/drivers/net/vxlan/drop.h
> new file mode 100644
> index 000000000000..6bcc6894fbbd
> --- /dev/null
> +++ b/drivers/net/vxlan/drop.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * VXLAN drop reason list.
> + */
> +
> +#ifndef VXLAN_DROP_H
> +#define VXLAN_DROP_H

Empty newline here please after the guard.

> +#include <linux/skbuff.h>
> +#include <net/dropreason.h>
> +
> +#define VXLAN_DROP_REASONS(R)			\
> +	/* deliberate comment for trailing \ */
> +
> +enum vxlan_drop_reason {
> +	__VXLAN_DROP_REASON = SKB_DROP_REASON_SUBSYS_VXLAN <<
> +				SKB_DROP_REASON_SUBSYS_SHIFT,

Maybe make SHIFT start at the same position as VXLAN, i.e. align the
former to the latter?

[...]

> diff --git a/drivers/net/vxlan/vxlan_private.h b/drivers/net/vxlan/vxlan_private.h
> index b35d96b78843..8720d7a1206f 100644
> --- a/drivers/net/vxlan/vxlan_private.h
> +++ b/drivers/net/vxlan/vxlan_private.h
> @@ -8,6 +8,7 @@
>  #define _VXLAN_PRIVATE_H
>  
>  #include <linux/rhashtable.h>

Also an empty newline here.

> +#include "drop.h"
>  
>  extern unsigned int vxlan_net_id;
>  extern const u8 all_zeros_mac[ETH_ALEN + 2];
> diff --git a/include/net/dropreason.h b/include/net/dropreason.h
> index 56cb7be92244..2e5d158d670e 100644
> --- a/include/net/dropreason.h
> +++ b/include/net/dropreason.h
> @@ -29,6 +29,12 @@ enum skb_drop_reason_subsys {
>  	 */
>  	SKB_DROP_REASON_SUBSYS_OPENVSWITCH,
>  
> +	/**
> +	 * @SKB_DROP_REASON_SUBSYS_VXLAN: vxlan drop reason, see

"VXLAN", uppercase?

> +	 * drivers/net/vxlan/drop.h
> +	 */
> +	SKB_DROP_REASON_SUBSYS_VXLAN,
> +
>  	/** @SKB_DROP_REASON_SUBSYS_NUM: number of subsystems defined */
>  	SKB_DROP_REASON_SUBSYS_NUM
>  };

Thanks,
Olek