linux-kernel - Re: [PATCH] selftest/vDSO: Fix cross build for the random tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9py_zPhh4v7GqM-BMM_ey=nJ+1=+kkrjjAi4PGzmgf=PA@mail.gmail.com>
Date: Fri, 30 Aug 2024 17:58:19 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Mark Brown <broonie@...nel.org>
Cc: Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftest/vDSO: Fix cross build for the random tests

On Fri, Aug 30, 2024 at 5:42 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Fri, Aug 30, 2024 at 05:30:07PM +0200, Jason A. Donenfeld wrote:
> > On Fri, Aug 30, 2024 at 03:06:35PM +0100, Mark Brown wrote:
>
> > > The x86_64 build is still broken for me because nothing installs
> > > tools/arch/x86_64/vdso/vgetrandom-chacha.S (I beleive it's supposed to
> > > be copied from ./arch/x86/entry/vdso/vgetrandom-chacha.S but I don't see
> > > how?) but this at least fixes all the other architectures.
>
> > There should be a symlink installed for that. Are you using this tree?
>
> > https://git.kernel.org/pub/scm/linux/kernel/git/crng/random.git
>
> > That's where all these fixups are going for 6.12. (And yea, there are a
> > lot.)
>
> I was using -next, hopefully it's getting merged in there (I see the
> master branch is included).  This is also breaking in for example
> kernelci:
>
> https://storage.kernelci.org/next/master/next-20240830/x86_64/x86_64_defconfig/gcc-12/logs/kselftest.log
>
> in the same way.

Ahh yea it looks like that is running into the same thing as your v1,
which the v2 I posted fixes via SRCARCH:

make[4]: *** No rule to make target
'/tmp/kci/linux/tools/testing/selftests/../../../tools/arch/x86_64/vdso/vgetrandom-chacha.S',
needed by '/tmp/kci/linux/build/kselftest/vDSO/vdso_test_chacha'.
Stop.

Here it's looking for arch/x86_64/ instead of arch/x86/, because
$(ARCH) was used to interpolate the path instead of $(SRCARCH).