linux-kernel - Re: [PATCH v2] selftests: vDSO: fix cross build for getrandom and chacha tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0621305d-84d2-4943-ad6e-9d951dd7c337@sirena.org.uk>
Date: Fri, 30 Aug 2024 17:05:47 +0100
From: Mark Brown <broonie@...nel.org>
To: "Jason A. Donenfeld" <Jason@...c4.com>
Cc: Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: vDSO: fix cross build for getrandom and
 chacha tests

On Fri, Aug 30, 2024 at 05:54:35PM +0200, Jason A. Donenfeld wrote:
> From: Mark Brown <broonie@...nel.org>
> 
> Unlike the check for the standalone x86 test, the check for building the
> vDSO getrandom and chacaha tests looks at the architecture for the host
> rather than the architecture for the target when deciding if they should
> be built. Since the chacha test includes some assembler code this means
> that cross building with x86 as either the target or host is broken. Use
> a check for ARCH instead.
> 
> This also handles s a small complication in conditionalizing on x86_64
> but not x86, which requires defining the standard SRCARCH variable and
> being careful about which uname-m substitutions are done.
> 
> Fixes: 4920a2590e91 ("selftests/vDSO: add tests for vgetrandom")
> Signed-off-by: Mark Brown <broonie@...nel.org>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
> Mark - is this okay with you? I fixed the issue I mentioned.

That makes sense and appears to work for me so:

Tested-by: Mark Brown <broonie@...nel.org>
Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)