linux-kernel - Re: [PATCH v1] clk: meson: axg-audio: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1cb1589f-221a-4fee-b7c4-2556e2c14335@kernel.org>
Date: Fri, 30 Aug 2024 19:46:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jerome Brunet <jbrunet@...libre.com>, Chen Yufan <chenyufan@...o.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Kevin Hilman <khilman@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
 linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 opensource.kernel@...o.com
Subject: Re: [PATCH v1] clk: meson: axg-audio: Use dev_err_probe() to simplfy
 code

On 30/08/2024 16:46, Jerome Brunet wrote:
> On Fri 30 Aug 2024 at 16:01, Chen Yufan <chenyufan@...o.com> wrote:
> 
>> Use dev_err_probe() can make code a bit simpler.
> 
> It surely does but ...
> 
>>
>> Signed-off-by: Chen Yufan <chenyufan@...o.com>
>> ---
>>  drivers/clk/meson/axg-audio.c | 12 ++++--------
> 
> Why this driver alone ?
> 
> I have nothing against the change you are doing but I would not want to get a
> single patch for each and every amlogic clock drivers.
> 

Look here:
https://lore.kernel.org/all/?q=f:@vivo.com
There is a like a flood of trivial patches started last two weeks. Not
sure if there is any coordination, any oversight or review. Few trivial
ones were introducing bugs, so I suggest caution.

Best regards,
Krzysztof