linux-kernel - Re: [PATCH v3] pinctrl: madera: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71c83616-ea3d-48a4-a722-2fca696a96d1@kernel.org>
Date: Fri, 30 Aug 2024 19:57:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yan Zhen <yanzhen@...o.com>, ckeepax@...nsource.cirrus.com,
 rf@...nsource.cirrus.com, linus.walleij@...aro.org
Cc: linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
 linux-kernel@...r.kernel.org, opensorce.kernel@...o.com
Subject: Re: [PATCH v3] pinctrl: madera: Simplify with dev_err_probe()

On 30/08/2024 10:43, Yan Zhen wrote:
> 
> diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
> index 898b197c3738..2932d7aba725 100644
> --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c
> +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
> @@ -1063,12 +1063,9 @@ static int madera_pin_probe(struct platform_device *pdev)
>  	if (pdata->gpio_configs) {
>  		ret = pinctrl_register_mappings(pdata->gpio_configs,
>  						pdata->n_gpio_configs);
> -		if (ret) {
> -			dev_err(priv->dev,
> -				"Failed to register pdata mappings (%d)\n",
> -				ret);
> -			return ret;
> -		}
> +		if (ret)
> +			return dev_err_probe(priv->dev, ret,
> +						"Failed to register pdata mappings\n");

Another example, one of many from @vivo.com, where you touch one line
and leave everything else not modified.

Are you going to send 5 different patches - one per each line? You
generate tremendous amount of work for reviewers, just to ramp up your
stats in company.

Best regards,
Krzysztof