linux-kernel - Re: [PATCH v2 1/2] Tracking cgroup-level niced CPU time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtIgdEt9RSU4MCIP@slm.duckdns.org>
Date: Fri, 30 Aug 2024 09:41:40 -1000
From: Tejun Heo <tj@...nel.org>
To: Joshua Hahn <joshua.hahnjy@...il.com>
Cc: cgroups@...r.kernel.org, hannes@...xchg.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	lizefan.x@...edance.com, mkoutny@...e.com, shuah@...nel.org
Subject: Re: [PATCH v2 1/2] Tracking cgroup-level niced CPU time

On Fri, Aug 30, 2024 at 07:19:38AM -0700, Joshua Hahn wrote:
> From: Joshua Hahn <joshua.hahn6@...il.com>
> 
> Cgroup-level CPU statistics currently include time spent on
> user/system processes, but do not include niced CPU time (despite
> already being tracked). This patch exposes niced CPU time to the
> userspace, allowing users to get a better understanding of their
> hardware limits and can facilitate more informed workload distribution.
> 
> A new field 'ntime' is added to struct cgroup_base_stat as opposed to
> struct task_cputime to minimize footprint.

Patch looks fine to me but can you please do the followings?

- Add subsystem prefix to the patch titles. Look other commits for examples.

- Add Signed-off-by to both.

Thanks.

-- 
tejun