linux-kernel - Re: [PATCH 02/21] drm: print clone mode status in atomic state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <092a7427-8971-4ee4-a417-52653ed892a4@quicinc.com>
Date: Fri, 30 Aug 2024 12:42:26 -0700
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Rob Clark <robdclark@...il.com>, <quic_abhinavk@...cinc.com>,
        Sean Paul
	<sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        "David
 Airlie" <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        "Maarten
 Lankhorst" <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>, <quic_ebharadw@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        Rob Clark <robdclark@...omium.org>
Subject: Re: [PATCH 02/21] drm: print clone mode status in atomic state



On 8/30/2024 9:38 AM, Dmitry Baryshkov wrote:
> On Thu, Aug 29, 2024 at 01:48:23PM GMT, Jessica Zhang wrote:
>> Add clone mode status to the DRM atomic print state
>>
>> Signed-off-by: Jessica Zhang <quic_jesszhan@...cinc.com>
>> ---
>>   drivers/gpu/drm/drm_atomic.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
>> index 07b4b394e3bf..145d6a758d4d 100644
>> --- a/drivers/gpu/drm/drm_atomic.c
>> +++ b/drivers/gpu/drm/drm_atomic.c
>> @@ -455,6 +455,7 @@ static void drm_atomic_crtc_print_state(struct drm_printer *p,
>>   	drm_printf(p, "\tconnector_mask=%x\n", state->connector_mask);
>>   	drm_printf(p, "\tencoder_mask=%x\n", state->encoder_mask);
>>   	drm_printf(p, "\tmode: " DRM_MODE_FMT "\n", DRM_MODE_ARG(&state->mode));
>> +	drm_printf(p, "\tin_clone_mode=%d\n", drm_crtc_in_clone_mode(crtc->state));
> 
> We have encoder_mask two lines above. What is the benefit of having the
> separate in_clone_mode?

Hi Dmitry,

I was thinking that this would be an easy way to note if a CRTC was in 
clone mode, but I can see why this is redundant.

Will drop this patch.

Thanks,

Jessica Zhang

> 
>>   
>>   	if (crtc->funcs->atomic_print_state)
>>   		crtc->funcs->atomic_print_state(p, state);
>>
>> -- 
>> 2.34.1
>>
> 
> -- 
> With best wishes
> Dmitry