linux-kernel - Re: [PATCH v1] gpio: stmpe: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYhi1syb+-PO41q18=rU0aykgNKzg2j7zmGQyH6Vbjqgg@mail.gmail.com>
Date: Sat, 31 Aug 2024 00:48:38 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: brgl@...ev.pl, mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com, 
	linux-gpio@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	opensource.kernel@...o.com
Subject: Re: [PATCH v1] gpio: stmpe: Simplify with dev_err_probe()

On Thu, Aug 29, 2024 at 3:11 PM Shen Lichuan <shenlichuan@...o.com> wrote:

> Use dev_err_probe() to simplify the error path and unify a message
> template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
>
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths.
>
> Signed-off-by: Shen Lichuan <shenlichuan@...o.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij