linux-kernel - Re: [PATCH v1] tty: serial: ma35d1: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <650ec430-715a-41d5-bbac-15dece73c632@kernel.org>
Date: Fri, 30 Aug 2024 10:07:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yu Jiaoliang <yujiaoliang@...o.com>, Jacky Huang <ychuang3@...oton.com>,
 Shan-Chun Hung <schung@...oton.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] tty: serial: ma35d1: Simplify with dev_err_probe()

On 29/08/2024 10:53, Yu Jiaoliang wrote:
> Error handling in probe() can be a bit simpler with dev_err_probe().
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> ---
>  drivers/tty/serial/ma35d1_serial.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
> index 3b4206e815fe..09d42a4054b3 100644
> --- a/drivers/tty/serial/ma35d1_serial.c
> +++ b/drivers/tty/serial/ma35d1_serial.c
> @@ -692,10 +692,9 @@ static int ma35d1serial_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  
>  	ret = of_alias_get_id(pdev->dev.of_node, "serial");
> -	if (ret < 0) {
> -		dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> -		return ret;
> -	}
> +	if (ret < 0)
> +		return dev_err_probe(&pdev->dev, ret, "failed to get alias/pdev id\n");

This is kind of silly... You change part which cannot defer, but you
leave second dev_err() intact which actually would benefit from handling
defer and dev_err_probe().

You either do not understand the function at all or you split patches in
some artificial, fake way just to generate multiple patches.

That's pointless.

Best regards,
Krzysztof