linux-kernel - Re: [PATCH v1] bus: qcom: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76fb94fb-abb9-4cb7-a477-9839d1bc6287@kernel.org>
Date: Fri, 30 Aug 2024 10:09:31 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yu Jiaoliang <yujiaoliang@...o.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] bus: qcom: Simplify with dev_err_probe()

On 29/08/2024 14:41, Yu Jiaoliang wrote:
> Error handling in probe() can be a bit simpler with dev_err_probe().
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
> ---
>  drivers/bus/qcom-ebi2.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
> index c1fef1b4bd89..dbd6a99bcc99 100644
> --- a/drivers/bus/qcom-ebi2.c
> +++ b/drivers/bus/qcom-ebi2.c
> @@ -308,10 +308,8 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
>  		return PTR_ERR(ebi2xclk);
>  
>  	ret = clk_prepare_enable(ebi2xclk);
> -	if (ret) {
> -		dev_err(dev, "could not enable EBI2X clk (%d)\n", ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "could not enable EBI2X clk\n");
>  
>  	ebi2clk = devm_clk_get(dev, "ebi2");
>  	if (IS_ERR(ebi2clk)) {


This cannot defer, so not much benefits. And again you change only one
place.

That's pointless and churn.

Best regards,
Krzysztof