linux-kernel - Re: [PATCH v1] bus: qcom: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a79f02e-2da2-4b6f-a00e-7511a21f72e3@vivo.com>
Date: Fri, 30 Aug 2024 08:21:20 +0000
From: 于佼良 <yujiaoliang@...o.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: opensource.kernel <opensource.kernel@...o.com>, Bjorn Andersson
	<andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] bus: qcom: Simplify with dev_err_probe()

在 2024/8/30 16:09, Krzysztof Kozlowski 写道:
> On 29/08/2024 14:41, Yu Jiaoliang wrote:
>> Error handling in probe() can be a bit simpler with dev_err_probe().
>>
>> Signed-off-by: Yu Jiaoliang <yujiaoliang@...o.com>
>> ---
>>   drivers/bus/qcom-ebi2.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
>> index c1fef1b4bd89..dbd6a99bcc99 100644
>> --- a/drivers/bus/qcom-ebi2.c
>> +++ b/drivers/bus/qcom-ebi2.c
>> @@ -308,10 +308,8 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
>>   		return PTR_ERR(ebi2xclk);
>>   
>>   	ret = clk_prepare_enable(ebi2xclk);
>> -	if (ret) {
>> -		dev_err(dev, "could not enable EBI2X clk (%d)\n", ret);
>> -		return ret;
>> -	}
>> +	if (ret)
>> +		return dev_err_probe(dev, ret, "could not enable EBI2X clk\n");
>>   
>>   	ebi2clk = devm_clk_get(dev, "ebi2");
>>   	if (IS_ERR(ebi2clk)) {
>
> This cannot defer, so not much benefits. And again you change only one
> place.
>
> That's pointless and churn.
>
> Best regards,
> Krzysztof
>
I apologize for the oversight. I will reconsider this modification and 
submit patches according to the granularity of the subsystem.

Best Regards,

Yu