linux-kernel - Re: [PATCH v2] platform/x86: dell-smbios: Fix error path in dell_smbios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172501191967.1828.1763222607712237074.b4-ty@linux.intel.com>
Date: Fri, 30 Aug 2024 12:58:39 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Mario Limonciello <mario.limonciello@...l.com>, 
 Aleksandr Mishin <amishin@...rgos.ru>
Cc: Hans de Goede <hdegoede@...hat.com>, Lyndon Sanche <lsanche@...deno.ca>, 
 Armin Wolf <W_Armin@....de>, "Darren Hart (VMware)" <dvhart@...radead.org>, 
 Edward O'Callaghan <quasisec@...gle.com>, 
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] platform/x86: dell-smbios: Fix error path in
 dell_smbios_init()

On Fri, 30 Aug 2024 09:54:28 +0300, Aleksandr Mishin wrote:

> In case of error in build_tokens_sysfs(), all the memory that has been
> allocated is freed at end of this function. But then free_group() is
> called which performs memory deallocation again.
> 
> Also, instead of free_group() call, there should be exit_dell_smbios_smm()
> and exit_dell_smbios_wmi() calls, since there is initialization, but there
> is no release of resources in case of an error.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: dell-smbios: Fix error path in dell_smbios_init()
      commit: ffc17e1479e8e9459b7afa80e5d9d40d0dd78abb

--
 i.