linux-kernel - Re: [PATCH 16/22] dt-bindings: qcom: geni-se: document support for SA8255P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1941ebf9-8bcf-49f5-bf69-cb2c66435b9b@kernel.org>
Date: Fri, 30 Aug 2024 11:58:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, rafael@...nel.org,
 viresh.kumar@...aro.org, herbert@...dor.apana.org.au, davem@...emloft.net,
 sudeep.holla@....com, andi.shyti@...nel.org, tglx@...utronix.de,
 will@...nel.org, joro@...tes.org, jassisinghbrar@...il.com, lee@...nel.org,
 linus.walleij@...aro.org, amitk@...nel.org, thara.gopinath@...il.com,
 broonie@...nel.org, wim@...ux-watchdog.org, linux@...ck-us.net,
 robin.murphy@....com, cristian.marussi@....com, rui.zhang@...el.com,
 lukasz.luba@....com, vkoul@...nel.org, quic_gurus@...cinc.com,
 agross@...nel.org, bartosz.golaszewski@...aro.org, quic_rjendra@...cinc.com,
 robimarko@...il.com, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-crypto@...r.kernel.org,
 arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-i2c@...r.kernel.org, iommu@...ts.linux.dev,
 linux-gpio@...r.kernel.org, linux-serial@...r.kernel.org,
 linux-spi@...r.kernel.org, linux-watchdog@...r.kernel.org,
 kernel@...cinc.com, quic_psodagud@...cinc.com, quic_tsoni@...cinc.com,
 quic_shazhuss@...cinc.com, Praveen Talari <quic_ptalari@...cinc.com>
Subject: Re: [PATCH 16/22] dt-bindings: qcom: geni-se: document support for
 SA8255P

On 29/08/2024 16:23, Nikunj Kela wrote:
> 
> On 8/29/2024 12:42 AM, Krzysztof Kozlowski wrote:
>> On Wed, Aug 28, 2024 at 01:37:15PM -0700, Nikunj Kela wrote:
>>> Add "qcom,sa8255p-geni-se-qup" compatible for representing QUP on
>>> SA8255p.
>>>
>>> Clocks are being managed by the firmware VM and not required on
>>> SA8255p Linux VM hence removing it from required list.
>>>
>>> CC: Praveen Talari <quic_ptalari@...cinc.com>
>>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>>> ---
>>>  .../bindings/soc/qcom/qcom,geni-se.yaml       | 47 +++++++++++++++++--
>>>  1 file changed, 43 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>>> index 7b031ef09669..40e3a3e045da 100644
>>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>>> @@ -22,17 +22,16 @@ properties:
>>>      enum:
>>>        - qcom,geni-se-qup
>>>        - qcom,geni-se-i2c-master-hub
>>> +      - qcom,sa8255p-geni-se-qup
>> Same problems. If you decide to use generic compatibles, it means it
>> covers all devices. Otherwise it does not make any sense.
> 
> Hi Krzysztof,
> 
> SA8255p platform is not compatible with generic ones. At the time
> generic compatibles were added, no one thought of such platform will

That's kind of obvious and expected yet these were added...

> appear in future. Please advise what should we do in this case?

I don't know. We keep telling - do not use generic compatibles, because
you will have something like this, but people use generic compatibles -
so what can I say? I told you so?

Can we get agreement that using generic compatibles is a wrong idea? Or
sort of promise - we won't use them? Or policy? I don't know, we can
move on assuming this was a mistake 8 years ago, approaches evolve,
reviews change, but I am just afraid I will be repeating the same to
several future contributions and every time come with long arguments
exhausting my energy - don't add generic compatibles.

If devices are not compatible, I suggest different bindings.

Best regards,
Krzysztof