linux-kernel - Re: [PATCH 14/22] dt-bindings: arm-smmu: document the support on SA8255p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6c1a81e-1533-4a17-8d6a-49a209a38557@kernel.org>
Date: Fri, 30 Aug 2024 12:00:36 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nikunj Kela <quic_nkela@...cinc.com>
Cc: andersson@...nel.org, konradybcio@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, rafael@...nel.org,
 viresh.kumar@...aro.org, herbert@...dor.apana.org.au, davem@...emloft.net,
 sudeep.holla@....com, andi.shyti@...nel.org, tglx@...utronix.de,
 will@...nel.org, joro@...tes.org, jassisinghbrar@...il.com, lee@...nel.org,
 linus.walleij@...aro.org, amitk@...nel.org, thara.gopinath@...il.com,
 broonie@...nel.org, wim@...ux-watchdog.org, linux@...ck-us.net,
 robin.murphy@....com, cristian.marussi@....com, rui.zhang@...el.com,
 lukasz.luba@....com, vkoul@...nel.org, quic_gurus@...cinc.com,
 agross@...nel.org, bartosz.golaszewski@...aro.org, quic_rjendra@...cinc.com,
 robimarko@...il.com, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org, linux-crypto@...r.kernel.org,
 arm-scmi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-i2c@...r.kernel.org, iommu@...ts.linux.dev,
 linux-gpio@...r.kernel.org, linux-serial@...r.kernel.org,
 linux-spi@...r.kernel.org, linux-watchdog@...r.kernel.org,
 kernel@...cinc.com, quic_psodagud@...cinc.com, quic_tsoni@...cinc.com,
 quic_shazhuss@...cinc.com
Subject: Re: [PATCH 14/22] dt-bindings: arm-smmu: document the support on
 SA8255p

On 29/08/2024 17:39, Nikunj Kela wrote:
> 
> On 8/29/2024 12:36 AM, Krzysztof Kozlowski wrote:
>> On Wed, Aug 28, 2024 at 01:37:13PM -0700, Nikunj Kela wrote:
>>> Add compatible for smmu representing support on SA8255p.
>>>
>>> Signed-off-by: Nikunj Kela <quic_nkela@...cinc.com>
>>> ---
>>>  Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>> Your subjects contain quite redundant/excessive information. In the same
>> time they lack information about device. 
>>
>> 1. s/document the support on/add/
>> 2. s/SA8255p/SA8255p SMMU-or-whatever-device-it-is/
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> Best regards,
>> Krzysztof
> 
> Okay. I thought arm-smmu tag already indicate which device this patch is
> for but would put SMMU explicitly in the subject.

arm,smmu indicates the binding file which might be or might not exactly
be the same as actual device. Sometimes they have difference names. I am
not saying that it would be beneficial here, but some other patches
could benefit probably.

Best regards,
Krzysztof