linux-kernel - Re: [EXT] Re: [PATCH] wifi: mwifiex: avoid AP and STA running on different channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtGpX6dZQo3oywwT@pengutronix.de>
Date: Fri, 30 Aug 2024 13:13:35 +0200
From: Sascha Hauer <s.hauer@...gutronix.de>
To: David Lin <yu-hao.lin@....com>
Cc: Francesco Dolcini <francesco@...cini.it>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"briannorris@...omium.org" <briannorris@...omium.org>,
	"kvalo@...nel.org" <kvalo@...nel.org>,
	Pete Hsieh <tsung-hsien.hsieh@....com>
Subject: Re: [EXT] Re: [PATCH] wifi: mwifiex: avoid AP and STA running on
 different channel

On Fri, Aug 30, 2024 at 10:58:50AM +0000, David Lin wrote:
> > From: Sascha Hauer <s.hauer@...gutronix.de>
> > Sent: Friday, August 30, 2024 5:19 PM
> > To: Francesco Dolcini <francesco@...cini.it>
> > Cc: David Lin <yu-hao.lin@....com>; linux-wireless@...r.kernel.org;
> > linux-kernel@...r.kernel.org; briannorris@...omium.org; kvalo@...nel.org;
> > Pete Hsieh <tsung-hsien.hsieh@....com>
> > Subject: [EXT] Re: [PATCH] wifi: mwifiex: avoid AP and STA running on
> > different channel
> > 
> > On Fri, Aug 30, 2024 at 10:10:30AM +0200, Francesco Dolcini wrote:
> > > +Sascha, that just sent a patch to handle the same issue.
> > >
> > > On Fri, Aug 30, 2024 at 11:06:30AM +0800, David Lin wrote:
> > > > Current firmware doesn't support AP and STA running on different
> > > > channels simultaneously.
> > > > FW crash would occur in such case.
> > > > This patch avoids the issue by disabling AP and STA to run on
> > > > different channels.
> > >
> > > Is this a generic issue of specific of some firmware version? Asking
> > > since the driver as you know is supporting multiple Wi-Fi device.
> > 
> > The driver does, unfortunately the hardware does not.
> > 
> > I learned this the hard way. When an accesspoint is running on uap0 and
> > you want to connect to an accesspoint on mlan0 then it won't work when
> > that accesspoint is on a different channel.
> > 
> > Likewise, when you are creating an accesspoint on uap0 using channel A and
> > another one on channel B then you'll notice that both accesspoints will end
> > up using channel A.
> > 
> > It took me a while to find that out. In the end I found the same channel
> > check in the nxpwifi driver.
> > 
> > Sascha
> > 
> 
> Yes, this patch is backported from nxpwifi (same as another patch for AP DFS mode).
> Because Mwifiex supports connect/disconnect and separate auth/assoc, I think I will
> clean up the code and create patch v2 later.

Gna, I didn't notice that I haven't answered to my own patch, but to
your patch addressing the same problem a few hours later ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |