linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node and gpio-hog names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240830112107.z2lxw3hqq627h3pz@lcpd911>
Date: Fri, 30 Aug 2024 16:51:07 +0530
From: Dhruva Gole <d-gole@...com>
To: Nishanth Menon <nm@...com>
CC: Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>, Tero Kristo
	<kristo@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        Roger Quadros <rogerq@...nel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am642-evm-nand: Rename pinctrl node
 and gpio-hog names

Hi,

On Aug 30, 2024 at 05:27:09 -0500, Nishanth Menon wrote:
> Rename the pin mux and gpio-hog node names to match up with binding
> rules. This fixes dtbs_check warnings:
> 'gpmc0-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+'
> 'gpio0-36' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$'
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
> Cc: Roger Quadros <rogerq@...nel.org>
> 
> This is a trivial fix, so applying Fixes seemed over-board.
> 
>  arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> index f08c0e272b53..f91589818e32 100644
> --- a/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso
> @@ -12,7 +12,7 @@
>  #include "k3-pinctrl.h"
>  
>  &main_pmx0 {
> -	gpmc0_pins_default: gpmc0-pins-default {
> +	gpmc0_pins_default: gpmc0-default-pins {

I mean, if you are anyway renaming,
s/gpmc0_pins_default/gpmc0_default_pins

>  		bootph-all;
>  		pinctrl-single,pins = <
>  			AM64X_IOPAD(0x0094, PIN_INPUT, 7) /* (T19) GPMC0_BE1n.GPIO0_36 */
> @@ -50,7 +50,7 @@ AM64X_IOPAD(0x00a4, PIN_OUTPUT, 0) /* (N17) GPMC0_DIR */
>  };
>  
>  &main_gpio0 {
> -	gpio0-36 {
> +	gpmc0-hog {
>  		bootph-all;
>  		gpio-hog;
>  		gpios = <36 0>;

With the change,
Reviewed-by: Dhruva Gole <d-gole@...com>

-- 
Best regards,
Dhruva Gole
Texas Instruments Incorporated