linux-kernel - Re: [PATCH v4 4/4] riscv: dts: sophgo: Add LicheeRV Nano board device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB4953AB5F2E922EA4E1E74184BB972@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Fri, 30 Aug 2024 19:20:20 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Thomas Bonnefille <thomas.bonnefille@...tlin.com>, 
	Chen Wang <unicorn_wang@...look.com>, Inochi Amaoto <inochiama@...look.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Chao Wei <chao.wei@...hgo.com>, Conor Dooley <conor@...nel.org>
Cc: Albert Ou <aou@...s.berkeley.edu>, Palmer Dabbelt <palmer@...belt.com>, 
	Samuel Holland <samuel.holland@...ive.com>, Thomas Gleixner <tglx@...utronix.de>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Miquèl Raynal <miquel.raynal@...tlin.com>, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v4 4/4] riscv: dts: sophgo: Add LicheeRV Nano board
 device tree

On Fri, Aug 30, 2024 at 10:06:45AM GMT, Thomas Bonnefille wrote:
> > > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > > +/*
> > > > + * Copyright (C) 2024 Thomas Bonnefille <thomas.bonnefille@...tlin.com>
> > > > + */
> > > > +
> > > > +/dts-v1/;
> > > > +
> > > > +#include "sg2002.dtsi"
> > > > +
> > > > +/ {
> > > > +    model = "LicheeRV Nano B";
> > > > +    compatible = "sipeed,licheerv-nano-b",
> > > > "sipeed,licheerv-nano", "sophgo,sg2002";
> > > > +
> > > > +    aliases {
> > > > +        gpio0 = &gpio0;
> > > > +        gpio1 = &gpio1;
> > > > +        gpio2 = &gpio2;
> > > > +        gpio3 = &gpio3;
> > > > +        serial0 = &uart0;
> > > > +        serial1 = &uart1;
> > > > +        serial2 = &uart2;
> > > > +        serial3 = &uart3;
> > > > +        serial4 = &uart4;
> > > > +    };
> > > > +
> > > > +    chosen {
> > > > +        stdout-path = "serial0:115200n8";
> > > > +    };
> > > > +};
> > > > +
> > > > +&osc {
> > > > +    clock-frequency = <25000000>;
> > > > +};
> > > > +
> > > > +&sdhci0 {
> > > > +    status = "okay";
> > > > +    bus-width = <4>;
> > > > +    no-1-8-v;
> > > > +    no-mmc;
> > > > +    no-sdio;
> > > > +    disable-wp;
> > > > +};
> > > > +
> > > > +&uart0 {
> > > > +    status = "okay";
> > > > +};
> > > > +
> > > > +&uart1 {
> > > > +    status = "okay";
> > > > +};
> > > > +
> > > > +&i2c0 {
> > > > +    status = "okay";
> > > > +};
> > > > 
> > > > -- 
> > > > 2.45.2
> > > > 
> > > Have you test you patch with a real board? Especially
> > > for device "uart1" and "i2c0", I suspect your
> > > configuartion does not work by default.
> > 
> > Hi, Thomas Bonnefille,
> > 
> > Can you please double check and feedback, I want to confirm this before
> > acking this change.
> > 
> > As you know, rc6 will come next week and I'm planning a pr next week.
> > 
> > Regards,
> > 
> > Chen
> > 
> Hello Chen and Inochi,
> 
> I'm really sorry, indeed, those nodes certainly don't work, it was a mistake
> on my side introduced between v1 and v2.
> However, I can ensure that "uart0" and "sdhci0" are working fine.
> May I suggest to remove those two nodes? I can send a new iteration if it's
> easier for you to handle?

As you need a new version, please add pinctrl node and necessary pin
configuration. And I will take the first two binding patch. So there
is no need to add them anymore.

The pinctrl patch (note it also needs a dependency):
https://lore.kernel.org/all/IA1PR20MB4953DC78BB0FE0C57EA94F91BBB32@IA1PR20MB4953.namprd20.prod.outlook.com/

Regard,
Inochi