linux-kernel - Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtG6CYPF9hUHaAqZ@zx2c4.com>
Date: Fri, 30 Aug 2024 14:24:41 +0200
From: "Jason A. Donenfeld" <Jason@...c4.com>
To: Xi Ruoyao <xry111@...111.site>
Cc: Tiezhu Yang <yangtiezhu@...ngson.cn>,
	Huacai Chen <chenhuacai@...nel.org>,
	WANG Xuerui <kernel@...0n.name>, linux-crypto@...r.kernel.org,
	loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Jinyang He <hejinyang@...ngson.cn>, Arnd Bergmann <arnd@...db.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH v5] LoongArch: vDSO: Wire up getrandom() vDSO
 implementation

On Fri, Aug 30, 2024 at 05:05:38PM +0800, Xi Ruoyao wrote:
> On Thu, 2024-08-29 at 16:44 +0200, Jason A. Donenfeld wrote:
> > > So get_vdso_data() + VVAR_LOONGARCH_PAGES_START * PAGE_SIZE should have
> > > already "jumped over" the time-ns vdso data.
> > 
> > Oh good. Thanks for checking. So it sounds like there's just Huacai's
> > set of comments and we're good.
> 
> Both Huacai and I (we've discussed a little off the list) think it seems
> more natural to separate the implementation and the self test into two
> patches.  Do you think it's acceptable?  If not we can live with one
> consolidated patch though.

I'm not such a fan, as wiring up the test makes the whole thing more
"hermetic", but it also doesn't matter to me that much, so if you two
prefer that, that's fine with me and I'll commit it like that.