linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6ull-seeed-npi: fix fsl,pins property in tscgrp pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae9c8916-27b4-4296-b827-92336a158294@linumiz.com>
Date: Sun, 1 Sep 2024 16:19:26 +0530
From: Parthiban <parthiban@...umiz.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Michael Trimarchi <michael@...rulasolutions.com>,
 Matteo Lisi <matteo.lisi@...icam.com>,
 Jagan Teki <jagan@...rulasolutions.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: parthiban@...umiz.com, stable@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6ull-seeed-npi: fix fsl,pins property in
 tscgrp pinctrl

Thanks.

On 8/31/24 3:41 PM, Krzysztof Kozlowski wrote:
> The property is "fsl,pins", not "fsl,pin".  Wrong property means the pin
> configuration was not applied.  Fixes dtbs_check warnings:
> 
>   imx6ull-seeed-npi-dev-board-emmc.dtb: pinctrl@...0000: uart1grp: 'fsl,pins' is a required property
>   imx6ull-seeed-npi-dev-board-emmc.dtb: pinctrl@...0000: uart1grp: 'fsl,pin' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Cc: <stable@...r.kernel.org>
> Fixes: e3b5697195c8 ("ARM: dts: imx6ull: add seeed studio NPi dev board")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Reviewed-by: Parthiban Nallathambi <parthiban@...umiz.com>

Thanks,
Parthiban
> ---
>  .../dts/nxp/imx/imx6ull-seeed-npi-dev-board.dtsi     | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-seeed-npi-dev-board.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-seeed-npi-dev-board.dtsi
> index 6bb12e0bbc7e..50654dbf62e0 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-seeed-npi-dev-board.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-seeed-npi-dev-board.dtsi
> @@ -339,14 +339,14 @@ MX6UL_PAD_JTAG_TRST_B__SAI2_TX_DATA	0x120b0
>  	};
>  
>  	pinctrl_uart1: uart1grp {
> -		fsl,pin = <
> +		fsl,pins = <
>  			MX6UL_PAD_UART1_TX_DATA__UART1_DCE_TX	0x1b0b1
>  			MX6UL_PAD_UART1_RX_DATA__UART1_DCE_RX	0x1b0b1
>  		>;
>  	};
>  
>  	pinctrl_uart2: uart2grp {
> -		fsl,pin = <
> +		fsl,pins = <
>  			MX6UL_PAD_UART2_TX_DATA__UART2_DCE_TX	0x1b0b1
>  			MX6UL_PAD_UART2_RX_DATA__UART2_DCE_RX	0x1b0b1
>  			MX6UL_PAD_UART2_CTS_B__UART2_DCE_CTS	0x1b0b1
> @@ -355,7 +355,7 @@ MX6UL_PAD_UART2_RTS_B__UART2_DCE_RTS	0x1b0b1
>  	};
>  
>  	pinctrl_uart3: uart3grp {
> -		fsl,pin = <
> +		fsl,pins = <
>  			MX6UL_PAD_UART3_TX_DATA__UART3_DCE_TX	0x1b0b1
>  			MX6UL_PAD_UART3_RX_DATA__UART3_DCE_RX	0x1b0b1
>  			MX6UL_PAD_UART3_CTS_B__UART3_DCE_CTS	0x1b0b1
> @@ -364,21 +364,21 @@ MX6UL_PAD_UART3_RTS_B__UART3_DCE_RTS	0x1b0b1
>  	};
>  
>  	pinctrl_uart4: uart4grp {
> -		fsl,pin = <
> +		fsl,pins = <
>  			MX6UL_PAD_UART4_TX_DATA__UART4_DCE_TX	0x1b0b1
>  			MX6UL_PAD_UART4_RX_DATA__UART4_DCE_RX	0x1b0b1
>  		>;
>  	};
>  
>  	pinctrl_uart5: uart5grp {
> -		fsl,pin = <
> +		fsl,pins = <
>  			MX6UL_PAD_UART5_TX_DATA__UART5_DCE_TX	0x1b0b1
>  			MX6UL_PAD_UART5_RX_DATA__UART5_DCE_RX	0x1b0b1
>  		>;
>  	};
>  
>  	pinctrl_usb_otg1_id: usbotg1idgrp {
> -		fsl,pin = <
> +		fsl,pins = <
>  			MX6UL_PAD_GPIO1_IO00__ANATOP_OTG1_ID	0x17059
>  		>;
>  	};