linux-kernel - Re: [PATCH] kbuild: remove recent dependency on "truncate" program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQFYs+iJovrf1b=cF_=Y5YBztDwVB4B+uh7PMgsaRFL4w@mail.gmail.com>
Date: Sun, 1 Sep 2024 20:43:10 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Tony Battersby <tonyb@...ernetics.com>
Cc: Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, 
	Daniel Gomez <da.gomez@...sung.com>, linux-kbuild@...r.kernel.org, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: remove recent dependency on "truncate" program

On Thu, Aug 29, 2024 at 10:51 PM Tony Battersby <tonyb@...ernetics.com> wrote:
>
> Remove the recently-added dependency on the truncate program for
> building the kernel.  truncate is not available when building the kernel
> under Yocto.  It could be added, but it would be better just to avoid
> the unnecessary dependency.
>
> Fixes: 1472464c6248 ("kbuild: avoid scripts/kallsyms parsing /dev/null")
> Signed-off-by: Tony Battersby <tonyb@...ernetics.com>


I have no objection.
'true' is a shell-builtin command, so it saves a process fork.


Applied to linux-kbuild. Thanks!


BTW, 'truncate' is used in drivers/firmware/efi/libstub/Makefile.zboot
(CONFIG_EFI_ZBOOT).
It seems to be no problem in Yocto.







> ---
>  scripts/link-vmlinux.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 070a319140e8..c27b4e969f20 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -215,7 +215,7 @@ kallsymso=
>  strip_debug=
>
>  if is_enabled CONFIG_KALLSYMS; then
> -       truncate -s0 .tmp_vmlinux.kallsyms0.syms
> +       true > .tmp_vmlinux.kallsyms0.syms
>         kallsyms .tmp_vmlinux.kallsyms0.syms .tmp_vmlinux0.kallsyms
>  fi
>
>
> base-commit: 3e9bff3bbe1355805de919f688bef4baefbfd436
> --
> 2.25.1
>


--
Best Regards
Masahiro Yamada