[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240829180106.GA3382912@thelio-3990X>
Date: Thu, 29 Aug 2024 11:01:06 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Tony Battersby <tonyb@...ernetics.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>,
Nicolas Schier <nicolas@...sle.eu>,
Daniel Gomez <da.gomez@...sung.com>, linux-kbuild@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: remove recent dependency on "truncate" program
On Thu, Aug 29, 2024 at 09:51:25AM -0400, Tony Battersby wrote:
> Remove the recently-added dependency on the truncate program for
> building the kernel. truncate is not available when building the kernel
> under Yocto. It could be added, but it would be better just to avoid
> the unnecessary dependency.
>
> Fixes: 1472464c6248 ("kbuild: avoid scripts/kallsyms parsing /dev/null")
> Signed-off-by: Tony Battersby <tonyb@...ernetics.com>
Seems reasonable to me and appears to generate an identical result for
me.
Reviewed-by: Nathan Chancellor <nathan@...nel.org>
> ---
> scripts/link-vmlinux.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 070a319140e8..c27b4e969f20 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -215,7 +215,7 @@ kallsymso=
> strip_debug=
>
> if is_enabled CONFIG_KALLSYMS; then
> - truncate -s0 .tmp_vmlinux.kallsyms0.syms
> + true > .tmp_vmlinux.kallsyms0.syms
> kallsyms .tmp_vmlinux.kallsyms0.syms .tmp_vmlinux0.kallsyms
> fi
>
>
> base-commit: 3e9bff3bbe1355805de919f688bef4baefbfd436
> --
> 2.25.1
>
Powered by blists - more mailing lists