linux-kernel - Re: [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb433a53-47ac-41eb-bd21-013da93b0bb7@roeck-us.net>
Date: Sun, 1 Sep 2024 06:43:50 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Patrick Rudolph <patrick.rudolph@...ements.com>,
 linux-kernel@...r.kernel.org
Cc: Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay

On 7/17/24 07:42, Guenter Roeck wrote:
> Patrick,
> 
> On 7/17/24 00:29, Patrick Rudolph wrote:
>> Some drivers, like the max15301 or zl6100, are intentionally delaying
>> SMBus communications, to prevent transmission errors. As this is necessary
>> on additional PMBus compatible devices, implement a generic delay mechanism
>> in the pmbus core.
>>
>> Introduces two delay settings in the pmbus_driver_info struct, one applies
>> to every SMBus transaction and the other is for write transaction only.
>> Once set by the driver the SMBus traffic, using the generic pmbus access
>> helpers, is automatically delayed when necessary.
>>
>> The two settings are:
>> access_delay:
>>    - Unit in microseconds
>>    - Stores the accessed timestamp after every SMBus access
>>    - Delays when necessary before the next SMBus access
>>
>> write_delay:
>>    - Unit in microseconds
>>    - Stores the written timestamp after a write SMBus access
>>    - Delays when necessary before the next SMBus access
>>
>> This allows to drop the custom delay code from the drivers and easily
>> introduce this feature in additional pmbus drivers.
>>
>> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
>> ---
> 
> Sigh (sorry, but this isn't your first patch, and you should know).
> 
> Change log goes here.
> 

Maybe I was not explicit enough, or maybe I offended you with the above.
If so, I am sorry.

Either case, I am not accepting patches or patch series without change log.

Guenter