linux-kernel - Re: [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALNFmy24TreXDf+gGLmJd7h2F5Aaz1WXzw_76gWEuEo+M_GuoA@mail.gmail.com>
Date: Mon, 2 Sep 2024 09:59:08 +0200
From: Patrick Rudolph <patrick.rudolph@...ements.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-kernel@...r.kernel.org, Jean Delvare <jdelvare@...e.com>, 
	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v2 1/5] hwmon: pmbus: Implement generic bus access delay

On Sun, Sep 1, 2024 at 3:43 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 7/17/24 07:42, Guenter Roeck wrote:
> > Patrick,
> >
> > On 7/17/24 00:29, Patrick Rudolph wrote:
> >> Some drivers, like the max15301 or zl6100, are intentionally delaying
> >> SMBus communications, to prevent transmission errors. As this is necessary
> >> on additional PMBus compatible devices, implement a generic delay mechanism
> >> in the pmbus core.
> >>
> >> Introduces two delay settings in the pmbus_driver_info struct, one applies
> >> to every SMBus transaction and the other is for write transaction only.
> >> Once set by the driver the SMBus traffic, using the generic pmbus access
> >> helpers, is automatically delayed when necessary.
> >>
> >> The two settings are:
> >> access_delay:
> >>    - Unit in microseconds
> >>    - Stores the accessed timestamp after every SMBus access
> >>    - Delays when necessary before the next SMBus access
> >>
> >> write_delay:
> >>    - Unit in microseconds
> >>    - Stores the written timestamp after a write SMBus access
> >>    - Delays when necessary before the next SMBus access
> >>
> >> This allows to drop the custom delay code from the drivers and easily
> >> introduce this feature in additional pmbus drivers.
> >>
> >> Signed-off-by: Patrick Rudolph <patrick.rudolph@...ements.com>
> >> ---
> >
> > Sigh (sorry, but this isn't your first patch, and you should know).
> >
> > Change log goes here.
> >
>
> Maybe I was not explicit enough, or maybe I offended you with the above.
> If so, I am sorry.
>
> Either case, I am not accepting patches or patch series without change log.
>
> Guenter
>
Hi Guenter,
Thanks for reminding me and being patient.
It's a good habit to make no exceptions when it comes to the quality
of submitted patches.

Please find my updated patch series, this time with a changelog.
Patrick