linux-kernel - Re: [PATCH][next] scsi: mpt3sas: Remove trailing space after \n newline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0729c1a1-3d3c-4734-8e1a-6fd722b73e02@wanadoo.fr>
Date: Mon, 2 Sep 2024 19:14:12 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Colin Ian King <colin.i.king@...il.com>,
 Sathya Prakash <sathya.prakash@...adcom.com>,
 Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
 Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>,
 "James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>,
 MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] scsi: mpt3sas: Remove trailing space after \n
 newline

Le 02/09/2024 à 16:36, Colin Ian King a écrit :
> There is a extraneous space after a newline in an ioc_info message.
> Remove it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index 9a24f7776d64..ebe4cbbc16e4 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -8899,8 +8899,8 @@ _base_check_ioc_facts_changes(struct MPT3SAS_ADAPTER *ioc)
>   		if (!device_remove_in_progress) {
>   			ioc_info(ioc,
>   			    "Unable to allocate the memory for "
> -			    "device_remove_in_progress of sz: %d\n "
> -			    , pd_handles_sz);
> +			    "device_remove_in_progress of sz: %d\n",

Hi,

I think that the 2 parts of the string should be put on the same line.

Another call just a few lines above is already written like that.

CJ

> +			    pd_handles_sz);
>   			return -ENOMEM;
>   		}
>   		memset(device_remove_in_progress +