linux-kernel - Re: [PATCH v1 2/7] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7q2t5qolpvdsyqxpygpfk2gnoe2qqi3a2t6oapo5oydapqml7q@touxbad2royc>
Date: Mon, 2 Sep 2024 23:38:03 +0000
From: Alvin Šipraga <ALSI@...g-olufsen.dk>
To: Vasileios Amoiridis <vassilisamir@...il.com>
CC: "linux@...linux.org.uk" <linux@...linux.org.uk>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "airlied@...il.com" <airlied@...il.com>,
	"daniel@...ll.ch" <daniel@...ll.ch>, "linus.walleij@...aro.org"
	<linus.walleij@...aro.org>, "andrew@...n.ch" <andrew@...n.ch>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>, "olteanv@...il.com"
	<olteanv@...il.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"nico@...xnic.net" <nico@...xnic.net>, "arend.vanspriel@...adcom.com"
	<arend.vanspriel@...adcom.com>, "kvalo@...nel.org" <kvalo@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "saravanak@...gle.com"
	<saravanak@...gle.com>, "andriy.shevchenko@...ux.intel.com"
	<andriy.shevchenko@...ux.intel.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-wireless@...r.kernel.org"
	<linux-wireless@...r.kernel.org>, "brcm80211@...ts.linux.dev"
	<brcm80211@...ts.linux.dev>, "brcm80211-dev-list.pdl@...adcom.com"
	<brcm80211-dev-list.pdl@...adcom.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v1 2/7] net: dsa: realtek: rtl8365mb: Make use of
 irq_get_trigger_type()

On Tue, Sep 03, 2024 at 12:55:29AM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@...il.com>
> ---
>  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Alvin Šipraga <alsi@...g-olufsen.dk>

Btw, I think this is something for net-next (not a bugfix?), so you
would normally add the appropriate prefix, i.e. [PATCH net-next ...],
when sending to netdev.

> 
> diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
> index b9674f68b756..ad7044b295ec 100644
> --- a/drivers/net/dsa/realtek/rtl8365mb.c
> +++ b/drivers/net/dsa/realtek/rtl8365mb.c
> @@ -1740,7 +1740,7 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv)
>  	}
>  
>  	/* Configure chip interrupt signal polarity */
> -	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
> +	irq_trig = irq_get_trigger_type(irq);
>  	switch (irq_trig) {
>  	case IRQF_TRIGGER_RISING:
>  	case IRQF_TRIGGER_HIGH:
> -- 
> 2.25.1
>