linux-kernel - Re: [PATCH 2/2] cpufreq: ti-cpufreq: Make the AM625 efuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240902233439.z5kpszcwaswkch6q@bryanbrattlof.com>
Date: Mon, 2 Sep 2024 18:34:39 -0500
From: Bryan Brattlof <bb@...com>
To: Dhruva Gole <d-gole@...com>
CC: "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar
	<viresh.kumar@...aro.org>,
        Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>, <vibhore@...com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] cpufreq: ti-cpufreq: Make the AM625 efuse_offset 0

On September  2, 2024 thus sayeth Dhruva Gole:
> Since the efuse_offset is basically derived from the syscon node, we no
> longer need to use any efuse_offset for AM625. This is in line with how
> the AM62Ax and AM62Px are already doing.
> 
> Signed-off-by: Dhruva Gole <d-gole@...com>
> ---
>  drivers/cpufreq/ti-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index ba621ce1cdda..98e320832f78 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -313,7 +313,7 @@ static const struct soc_device_attribute k3_cpufreq_soc[] = {
>  
>  static struct ti_cpufreq_soc_data am625_soc_data = {
>  	.efuse_xlate = am625_efuse_xlate,
> -	.efuse_offset = 0x0018,
> +	.efuse_offset = 0x0,
>  	.efuse_mask = 0x07c0,
>  	.efuse_shift = 0x6,
>  	.rev_offset = 0x0014,

This may work but it really shouldn't. Unfortunately when I sent out the 
am62ax and am62px support I missed the .rev_offset and now it's pointed 
to some random spot in the WKUP_CTRL_MMR space. How it worked on my 
bench was complete luck (or bad luck depending on how we view this).

We'll need to pull out a OMAP3 chip and try to separate the OMAP and K3 
OPN decoding before we can move the .efuse_offset

~Bryan