linux-kernel - Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony board and VAR-SOM-MX8MP SoM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e294c334-8d02-4f56-b4ba-e63d94a70a12@kernel.org>
Date: Mon, 2 Sep 2024 09:47:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Tarang Raval <tarang.raval@...iconsignals.io>
Cc: Conor Dooley <conor+dt@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Hugo Villeneuve <hvilleneuve@...onoff.com>,
 Gregor Herburger <gregor.herburger@...tq-group.com>,
 Joao Paulo Goncalves <joao.goncalves@...adex.com>,
 Hiago De Franco <hiago.franco@...adex.com>,
 Mathieu Othacehe <m.othacehe@...il.com>,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Josua Mayer <josua@...id-run.com>, Yannic Moog <y.moog@...tec.de>,
 Li Yang <leoyang.li@....com>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: fsl: Add Variscite Symphony
 board and VAR-SOM-MX8MP SoM

On 02/09/2024 09:23, Tarang Raval wrote:
> Hi,
> 
>>> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp."
>>
>> ??? No, there is no difference. You did not test your patches either.
> 
> I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors.

Ah, you are right, I missed what actually changed.

> 
>> When I wrote "This is not correct", it means you should drop it.
>> Incorrect compatibles should not be added.
> 
> Sure I will Drop it.

I guess I wasn't precise. Please drop that one diff hunk.

Best regards,
Krzysztof