linux-kernel - Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <666217c6-c113-449d-bdb9-c3492d770c45@microchip.com>
Date: Mon, 2 Sep 2024 08:35:22 +0000
From: <Dharma.B@...rochip.com>
To: <claudiu.beznea@...on.dev>, <Manikandan.M@...rochip.com>,
	<andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
	<Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
	<jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
	<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
	<daniel@...ll.ch>, <Hari.PrasathGE@...rochip.com>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] drm/bridge: microchip-lvds: Revert
 clk_prepare_enable() in case of failure

On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> In case pm_runtime_get_sync() fails the clock remains enabled. Disable
> it to save power on this failure scenario.
> 
> Fixes: 179b0769fc5f ("drm/bridge: add lvds controller support for sam9x7")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...on.dev>
Reviewed-by: Dharma Balasubiramani <dharma.b@...rochip.com>
Tested-by: Dharma Balasubiramani <dharma.b@...rochip.com>
> ---
>   drivers/gpu/drm/bridge/microchip-lvds.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index b8313dad6072..027292ab0197 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -125,6 +125,7 @@ static void mchp_lvds_enable(struct drm_bridge *bridge)
> 
>          ret = pm_runtime_get_sync(lvds->dev);
>          if (ret < 0) {
> +               clk_disable_unprepare(lvds->pclk);
>                  dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
>                  return;
>          }
> --
> 2.39.2
> 


-- 
With Best Regards,
Dharma B.