[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3ceb248f-aa3a-4aa7-ac8b-dbfe9527f541@microchip.com>
Date: Mon, 2 Sep 2024 08:35:47 +0000
From: <Dharma.B@...rochip.com>
To: <claudiu.beznea@...on.dev>, <Manikandan.M@...rochip.com>,
<andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>, <rfoss@...nel.org>,
<Laurent.pinchart@...asonboard.com>, <jonas@...boo.se>,
<jernej.skrabec@...il.com>, <maarten.lankhorst@...ux.intel.com>,
<mripard@...nel.org>, <tzimmermann@...e.de>, <airlied@...il.com>,
<daniel@...ll.ch>, <Hari.PrasathGE@...rochip.com>
CC: <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] drm/bridge: microchip-lvds: Use
devm_platform_ioremap_resource()
On 27/08/24 9:42 pm, Claudiu Beznea wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The devm_platform_ioremap_resouce() does exactly what
> devm_ioremap_resource() combined with platform_get_resouce() does.
> Thus use it.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...on.dev>
Reviewed-by: Dharma Balasubiramani <dharma.b@...rochip.com>
Tested-by: Dharma Balasubiramani <dharma.b@...rochip.com>
> ---
> drivers/gpu/drm/bridge/microchip-lvds.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
> index f04831106eea..85aff8c5aaf4 100644
> --- a/drivers/gpu/drm/bridge/microchip-lvds.c
> +++ b/drivers/gpu/drm/bridge/microchip-lvds.c
> @@ -154,8 +154,7 @@ static int mchp_lvds_probe(struct platform_device *pdev)
>
> lvds->dev = dev;
>
> - lvds->regs = devm_ioremap_resource(lvds->dev,
> - platform_get_resource(pdev, IORESOURCE_MEM, 0));
> + lvds->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(lvds->regs))
> return PTR_ERR(lvds->regs);
>
> --
> 2.39.2
>
--
With Best Regards,
Dharma B.
Powered by blists - more mailing lists