linux-kernel - Re: [PATCH v1 2/2] gpio: zynq: Simplify using devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64cf8023-9bde-4c01-aeb7-0cfb8aa79a74@amd.com>
Date: Mon, 2 Sep 2024 12:58:59 +0200
From: Michal Simek <michal.simek@....com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
 Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
 Srinivas Neeli <srinivas.neeli@....com>, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 opensource.kernel@...o.com, Rong Qianfeng <rongqianfeng@...o.com>
Subject: Re: [PATCH v1 2/2] gpio: zynq: Simplify using devm_clk_get_enabled()

Hi Bart,

On 9/2/24 12:32, Bartosz Golaszewski wrote:
> On Tue, Aug 20, 2024 at 2:17 PM Rong Qianfeng <rongqianfeng@...o.com> wrote:
>>
>> Use devm_clk_get_enabled() simplify zynq_gpio_probe() and zynq_gpio_remove().
>>
>> Signed-off-by: Rong Qianfeng <rongqianfeng@...o.com>
>> ---
> 
> Michal,
> 
> This changes the order of operations in remove(), could you test it or
> at least give your Ack here?

Changes look good to me.
Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal