linux-kernel - Re: [PATCH v3] irqchip: madera: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874j6y6zqu.ffs@tglx>
Date: Mon, 02 Sep 2024 13:50:33 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Yan Zhen <yanzhen@...o.com>, ckeepax@...nsource.cirrus.com,
 rf@...nsource.cirrus.com
Cc: linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
 linux-kernel@...r.kernel.org, opensorce.kernel@...o.com, Yan Zhen
 <yanzhen@...o.com>
Subject: Re: [PATCH v3] irqchip: madera: Simplify with dev_err_probe()

On Fri, Aug 30 2024 at 16:46, Yan Zhen wrote:
> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
>
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.

Is fine? We don't care about fine. The question is whether it is correct
or not. And if so, then there wants to be an explanation why it is correct.

> Changes in v3:
> -Rewrite the subject as 'irqchip: madera:'.

Which is still wrong. Care to read Documentation/process/ ?

>  drivers/irqchip/irq-madera.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-madera.c b/drivers/irqchip/irq-madera.c
> index acceb6e7fa95..d5ad4466a140 100644
> --- a/drivers/irqchip/irq-madera.c
> +++ b/drivers/irqchip/irq-madera.c
> @@ -199,9 +199,8 @@ static int madera_irq_probe(struct platform_device *pdev)
>  		ret = regmap_update_bits(madera->regmap, MADERA_IRQ1_CTRL,
>  					 MADERA_IRQ_POL_MASK, 0);
>  		if (ret) {
> -			dev_err(&pdev->dev,
> -				"Failed to set IRQ polarity: %d\n", ret);
> -			return ret;
> +			return dev_err_probe(&pdev->dev, ret,
> +						"Failed to set IRQ polarity");

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#line-breaks

But that's moot as Krzysztof pointed out that this patch just picks a
random instance of the code for no reason.

Thanks,

        tglx