linux-kernel - Re: [PATCH v3] irqchip: madera: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecbea95e-e48a-4792-97cc-1c325cc7765e@kernel.org>
Date: Fri, 30 Aug 2024 19:56:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yan Zhen <yanzhen@...o.com>, ckeepax@...nsource.cirrus.com,
 rf@...nsource.cirrus.com, tglx@...utronix.de
Cc: linux-sound@...r.kernel.org, patches@...nsource.cirrus.com,
 linux-kernel@...r.kernel.org, opensorce.kernel@...o.com
Subject: Re: [PATCH v3] irqchip: madera: Simplify with dev_err_probe()

On 30/08/2024 10:46, Yan Zhen wrote:
> Switch to use dev_err_probe() to simplify the error path and
> unify a message template.
> 
> Using this helper is totally fine even if err is known to never
> be -EPROBE_DEFER.
> 
> The benefit compared to a normal dev_err() is the standardized format
> of the error code, it being emitted symbolically and the fact that
> the error code is returned which allows more compact error paths. 
> 
> Signed-off-by: Yan Zhen <yanzhen@...o.com>
> ---
> 
> Changes in v3:
> -Rewrite the subject as 'irqchip: madera:'.
> 
>  drivers/irqchip/irq-madera.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-madera.c b/drivers/irqchip/irq-madera.c
> index acceb6e7fa95..d5ad4466a140 100644
> --- a/drivers/irqchip/irq-madera.c
> +++ b/drivers/irqchip/irq-madera.c
> @@ -199,9 +199,8 @@ static int madera_irq_probe(struct platform_device *pdev)
>  		ret = regmap_update_bits(madera->regmap, MADERA_IRQ1_CTRL,
>  					 MADERA_IRQ_POL_MASK, 0);
>  		if (ret) {
> -			dev_err(&pdev->dev,
> -				"Failed to set IRQ polarity: %d\n", ret);
> -			return ret;
> +			return dev_err_probe(&pdev->dev, ret,
> +						"Failed to set IRQ polarity");

Another example, one of many from @vivo.com, where you touch one line
and leave everything else.

Are you going to send 5 different patches - one per each line? It's
nonsense.

Best regards,
Krzysztof