linux-kernel - Re: [PATCH 1/9] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3672523-11fe-42de-ad7b-643b396b8778@kernel.org>
Date: Tue, 3 Sep 2024 16:08:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: keke.li@...ogic.com, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kieran.bingham@...asonboard.com,
 laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com
Subject: Re: [PATCH 1/9] dt-bindings: media: Add amlogic,c3-mipi-csi2.yaml

On 03/09/2024 08:57, Keke Li via B4 Relay wrote:
> From: Keke Li <keke.li@...ogic.com>
> 
> c3-mipi-csi2 is used to receive mipi data
> from image sensor.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Keke Li <keke.li@...ogic.com>
> ---
>  .../bindings/media/amlogic,c3-mipi-csi2.yaml       | 130 +++++++++++++++++++++
>  1 file changed, 130 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml
> new file mode 100644
> index 000000000000..85d3088d6f9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-csi2.yaml
> @@ -0,0 +1,130 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-csi2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic C3 MIPI CSI-2 receiver
> +
> +maintainers:
> +  - Keke Li <keke.li@...ogic.com>
> +
> +description: |-

Do not need '|-' unless you need to preserve formatting.


> +  MIPI CSI-2 receiver contains CSI-2 RX PHY and host controller.
> +  It receives the MIPI data from the image sensor and sends MIPI data
> +  to MIPI adapter.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - amlogic,c3-mipi-csi2
> +
> +  reg:
> +    minItems: 3

Drop minItems

> +    maxItems: 3
> +
> +  reg-names:
> +    items:
> +      - const: csi_aphy
> +      - const: csi_dphy
> +      - const: csi_host

Drop csi_ everywhere

> +
> +  power-domains:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 2

Your code is random... Look how this is different than other list - reg.
Instead maxItems.

> +
> +  clock-names:
> +    items:
> +      - const: vapb
> +      - const: csi_phy0
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: input port node, connected to sensor.
> +
> +        properties:
> +          endpoint:
> +            $ref: video-interfaces.yaml#
> +            unevaluatedProperties: false
> +
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +            required:
> +              - data-lanes
> +
> +      port@1:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: output port node
> +
> +    required:
> +      - port@0
> +      - port@1
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - power-domains
> +  - clocks
> +  - clock-names
> +  - ports
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h>
> +    #include <dt-bindings/power/amlogic,c3-pwrc.h>
> +
> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        csi: csi@...18000 {
> +            compatible = "amlogic,c3-mipi-csi2";
> +

Drop blank line

> +            reg = <0x0 0xff018000 0x0 0x400>,
> +                  <0x0 0xff019000 0x0 0x300>,
> +                  <0x0 0xff01a000 0x0 0x100>;
> +

Drop blank line


> +            reg-names = "csi_aphy", "csi_dphy", "csi_host";
> +
> +            power-domains = <&pwrc PWRC_C3_MIPI_ISP_WRAP_ID>;
> +
> +            clocks =  <&clkc_periphs CLKID_VAPB>,
> +                      <&clkc_periphs CLKID_CSI_PHY0>;
> +

Drop blank line. That's poorly readable code.



Best regards,
Krzysztof