linux-kernel - Re: [PATCH 2/9] media: platform: Add c3 mipi csi2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f226ba2-2324-4c0c-91df-54f42938d9fb@kernel.org>
Date: Tue, 3 Sep 2024 16:10:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: keke.li@...ogic.com, Mauro Carvalho Chehab <mchehab@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kieran.bingham@...asonboard.com,
 laurent.pinchart@...asonboard.com, dan.scally@...asonboard.com
Subject: Re: [PATCH 2/9] media: platform: Add c3 mipi csi2 driver

On 03/09/2024 08:57, Keke Li via B4 Relay wrote:
> From: Keke Li <keke.li@...ogic.com>
> 
> This driver is used to receive mipi data from image sensor.
> 
> Signed-off-by: Keke Li <keke.li@...ogic.com>


...

> +static int c3_mipi_csi_probe(struct platform_device *pdev)
> +{
> +	struct device *dev = &pdev->dev;
> +	struct csi_device *csi;
> +	int ret;
> +
> +	csi = devm_kzalloc(dev, sizeof(*csi), GFP_KERNEL);
> +	if (!csi)
> +		return -ENOMEM;
> +
> +	csi->info = of_device_get_match_data(dev);
> +	csi->dev = dev;
> +
> +	ret = c3_mipi_csi_ioremap_resource(csi);
> +	if (ret) {
> +		dev_err(dev, "Failed to ioremap resource: %d\n", ret);
> +		return ret;
> +	}
> +
> +	ret = c3_mipi_csi_configure_clocks(csi);
> +	if (ret) {
> +		dev_err(dev, "Failed to configure clocks: %d\n", ret);
> +		return ret;

Syntax is return dev_err_probe. This was repeated multiple times, so
please organize some inside-Amlogic sessions so you will learn from
somebody's mistakes/reviews. That's way other developers do not repeat
the same issue.


Best regards,
Krzysztof