linux-kernel - Re: [PATCH -next] serial: 8250_aspeed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4nyenalsjnerwjwcuk5zwm52rptnc5jhjhz3yhsmo7qt3gffhs@qadnsjic7p24>
Date: Tue, 3 Sep 2024 17:49:54 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Liao Chen <liaochen4@...wei.com>
Cc: linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org, gregkh@...uxfoundation.org, 
	jirislaby@...nel.org, joel@....id.au, andrew@...econstruct.com.au, 
	andi.shyti@...ux.intel.com, andriy.shevchenko@...ux.intel.com, florian.fainelli@...adcom.com, 
	tglx@...utronix.de
Subject: Re: [PATCH -next] serial: 8250_aspeed_vuart: Enable module
 autoloading

Hello,

On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
> on the alias from of_device_id table.
> 
> Signed-off-by: Liao Chen <liaochen4@...wei.com>
> ---
>  drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
> index 53d8eee9b1c8..25c201cfb91e 100644
> --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
> +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
> @@ -561,6 +561,7 @@ static const struct of_device_id aspeed_vuart_table[] = {
>  	{ .compatible = "aspeed,ast2500-vuart" },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, aspeed_vuart_table);

I wonder if you found this entry missing by code review, or if you have
a machine with that UART and so you actually benefit.

Otherwise looks right to me.

Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)