linux-kernel - Re: [PATCH -next] serial: 8250_aspeed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ztc2-OuaL2IJI6QW@smile.fi.intel.com>
Date: Tue, 3 Sep 2024 19:19:04 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Liao Chen <liaochen4@...wei.com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-aspeed@...ts.ozlabs.org, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, joel@....id.au, andrew@...econstruct.com.au,
	andi.shyti@...ux.intel.com, florian.fainelli@...adcom.com,
	tglx@...utronix.de
Subject: Re: [PATCH -next] serial: 8250_aspeed_vuart: Enable module
 autoloading

On Tue, Sep 03, 2024 at 05:49:54PM +0200, Uwe Kleine-König wrote:
> On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote:

...

> I wonder if you found this entry missing by code review, or if you have
> a machine with that UART and so you actually benefit.

Using arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts in QEMU
I never experienced an issue. Seems due to defconfig having it =y.
(used arch/arm/configs/aspeed_g5_defconfig)

> Otherwise looks right to me.
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

-- 
With Best Regards,
Andy Shevchenko