linux-kernel - Re: [PATCH -next] serial: 8250_aspeed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e043ff91-773c-4f30-a709-5aa5f2215755@huawei.com>
Date: Fri, 6 Sep 2024 10:04:10 +0800
From: "liaochen (A)" <liaochen4@...wei.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
CC: <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-aspeed@...ts.ozlabs.org>,
	<gregkh@...uxfoundation.org>, <jirislaby@...nel.org>, <joel@....id.au>,
	<andrew@...econstruct.com.au>, <andi.shyti@...ux.intel.com>,
	<andriy.shevchenko@...ux.intel.com>, <florian.fainelli@...adcom.com>,
	<tglx@...utronix.de>
Subject: Re: [PATCH -next] serial: 8250_aspeed_vuart: Enable module
 autoloading

On 2024/9/3 23:49, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote:
>> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based
>> on the alias from of_device_id table.
>>
>> Signed-off-by: Liao Chen <liaochen4@...wei.com>
>> ---
>>   drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c
>> index 53d8eee9b1c8..25c201cfb91e 100644
>> --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c
>> +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c
>> @@ -561,6 +561,7 @@ static const struct of_device_id aspeed_vuart_table[] = {
>>   	{ .compatible = "aspeed,ast2500-vuart" },
>>   	{ },
>>   };
>> +MODULE_DEVICE_TABLE(of, aspeed_vuart_table);
> 
> I wonder if you found this entry missing by code review, or if you have
> a machine with that UART and so you actually benefit.

I found it from code review. Since this device could be compiled as a 
module, I think it is better to add this entry.

Thanks,
Chen

> 
> Otherwise looks right to me.
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
> 
> Best regards
> Uwe