[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240903172756.19235-1-kontakt@matthias-fetzer.de>
Date: Tue, 3 Sep 2024 19:27:56 +0200
From: Matthias Fetzer <kontakt@...thias-fetzer.de>
To: hmh@....eng.br,
hdegoede@...hat.com,
ilpo.jarvinen@...ux.intel.com,
ibm-acpi-devel@...ts.sourceforge.net,
platform-driver-x86@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Matthias Fetzer <kontakt@...thias-fetzer.de>
Subject: [PATCH] platform/x86: thinkpad_acpi: Fix uninitialized symbol
When the TPACPI_FAN_WR_ACPI_FANW branch is taken s stays uninitialized
and would be later used in a debug print.
Since the registers are always set to the same two static values inside the
branch s is initialized to 0.
Signed-off-by: Matthias Fetzer <kontakt@...thias-fetzer.de>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index 8f7053920884..4c1b0553f872 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -8318,7 +8318,7 @@ static int fan_set_level_safe(int level)
static int fan_set_enable(void)
{
- u8 s;
+ u8 s = 0;
int rc;
if (!fan_control_allowed)
--
2.46.0
Powered by blists - more mailing lists