linux-kernel - Re: [PATCH] platform/x86: thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05d4e489-c081-4edb-b203-88701b135b74@redhat.com>
Date: Wed, 4 Sep 2024 20:31:22 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Matthias Fetzer <kontakt@...thias-fetzer.de>, hmh@....eng.br,
 ilpo.jarvinen@...ux.intel.com, ibm-acpi-devel@...ts.sourceforge.net,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Fix uninitialized symbol

Hi,

On 9/3/24 7:27 PM, Matthias Fetzer wrote:
> When the TPACPI_FAN_WR_ACPI_FANW branch is taken s stays uninitialized
> and would be later used in a debug print.
> 
> Since the registers are always set to the same two static values inside the
> branch s is initialized to 0.
> 
> Signed-off-by: Matthias Fetzer <kontakt@...thias-fetzer.de>

Thank you.

I've applied this with the following tags added to the commit message:

Fixes: 57d0557dfa49 ("platform/x86: thinkpad_acpi: Add Thinkpad Edge E531 fan support")
Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
Closes: https://lore.kernel.org/platform-driver-x86/f99e558d-c62a-41eb-93b3-cf00c016d907@stanley.mountain/

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/thinkpad_acpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 8f7053920884..4c1b0553f872 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8318,7 +8318,7 @@ static int fan_set_level_safe(int level)
>  
>  static int fan_set_enable(void)
>  {
> -	u8 s;
> +	u8 s = 0;
>  	int rc;
>  
>  	if (!fan_control_allowed)