linux-kernel - Re: [PATCH] pwm: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+GVSwiEVRRcN5xL7pgOn7rRNLsWU8s-5ByCP4rpj9JGw@mail.gmail.com>
Date: Tue, 3 Sep 2024 14:19:01 -0500
From: Rob Herring <robh@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: Use of_property_read_bool()

On Thu, Aug 1, 2024 at 3:41 AM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Hello,
>
> On Wed, Jul 31, 2024 at 01:13:03PM -0600, Rob Herring (Arm) wrote:
> > Use of_property_read_bool() to read boolean properties rather than
> > of_get_property(). This is part of a larger effort to remove callers
> > of of_get_property() and similar functions. of_get_property() leaks
> > the DT property data pointer which is a problem for dynamically
> > allocated nodes which may be freed.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> >  drivers/pwm/pwm-omap-dmtimer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks good to me. Unless you object I'd apply with adding
> "omap-dmtimer: " to the short log.

No objection and sorry I missed that.

Rob