linux-kernel - Re: [PATCH] pwm: Use of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mwk24tc2fr2rwe2u7ynulxgjx5butzs6nuykxulx53vmhauczp@we73jfksuqpu>
Date: Wed, 4 Sep 2024 09:29:17 +0200
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Rob Herring <robh@...nel.org>
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: Use of_property_read_bool()

On Tue, Sep 03, 2024 at 02:19:01PM -0500, Rob Herring wrote:
> On Thu, Aug 1, 2024 at 3:41 AM Uwe Kleine-König
> <u.kleine-koenig@...libre.com> wrote:
> >
> > Hello,
> >
> > On Wed, Jul 31, 2024 at 01:13:03PM -0600, Rob Herring (Arm) wrote:
> > > Use of_property_read_bool() to read boolean properties rather than
> > > of_get_property(). This is part of a larger effort to remove callers
> > > of of_get_property() and similar functions. of_get_property() leaks
> > > the DT property data pointer which is a problem for dynamically
> > > allocated nodes which may be freed.
> > >
> > > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > > ---
> > >  drivers/pwm/pwm-omap-dmtimer.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Looks good to me. Unless you object I'd apply with adding
> > "omap-dmtimer: " to the short log.
> 
> No objection and sorry I missed that.

No problem for me, applied with the mentioned change to the short log to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)