linux-kernel - Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7688ac1c-14da-46a2-a5dc-f01c104485f8@quicinc.com>
Date: Tue, 3 Sep 2024 16:38:02 +0800
From: Jingyi Wang <quic_jingyw@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        Conor Dooley <conor@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property



On 9/3/2024 4:00 PM, Krzysztof Kozlowski wrote:
> On 03/09/2024 09:30, Jingyi Wang wrote:
>>
>>
>> On 9/3/2024 3:10 PM, Krzysztof Kozlowski wrote:
>>> On Tue, Sep 03, 2024 at 02:21:29PM +0800, Jingyi Wang wrote:
>>>> Add a property "num-banks" for errata.
>>>
>>> This you said in commit subject and we see in the diff. You *MUST*
>>> explain why.
>>>
Usually the num of LLCC banks is read from hardware, but there is errata
on some SoCs to get the wrong bank num from LLCC_COMMON_STATUS0. Add a
property "num-banks" to indicate the accurate data.
>>>>
>>>> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>>>> index 68ea5f70b75f..03241b719c98 100644
>>>> --- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>>>> +++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
>>>> @@ -56,6 +56,11 @@ properties:
>>>>      items:
>>>>        - const: multi-chan-ddr
>>>>  
>>>> +  num-banks:
>>>
>>> No vendor prefix? So this is generic property? Then add to some common
>>> schema with proper explanation WHY.
>>>

will qcom,num-banks be okay?

>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>> +    description:
>>>> +      The num of llcc banks
>>>
>>> And what are llcc (or LLCC?) banks?
>>>
>>>

LLCC banks means LLCC register regions with same memory size and reg offset
and different memory base for LLCC configuration.

>> Will add the vendor prefix and description in the next series.
> 
> You did not provide rationale nor answer to concerns so far.
> 
> Best regards,
> Krzysztof
> 
Thanks,
Jingyi