linux-kernel - Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d77a0178-7e6d-445b-bc08-3a63606bc598@kernel.org>
Date: Tue, 3 Sep 2024 10:56:15 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jingyi Wang <quic_jingyw@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Conor Dooley <conor@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: cache: qcom,llcc: add num-banks property

On 03/09/2024 10:38, Jingyi Wang wrote:
> 
> 
> On 9/3/2024 4:00 PM, Krzysztof Kozlowski wrote:
>> On 03/09/2024 09:30, Jingyi Wang wrote:
>>>
>>>
>>> On 9/3/2024 3:10 PM, Krzysztof Kozlowski wrote:
>>>> On Tue, Sep 03, 2024 at 02:21:29PM +0800, Jingyi Wang wrote:
>>>>> Add a property "num-banks" for errata.
>>>>
>>>> This you said in commit subject and we see in the diff. You *MUST*
>>>> explain why.
>>>>
> Usually the num of LLCC banks is read from hardware, but there is errata
> on some SoCs to get the wrong bank num from LLCC_COMMON_STATUS0. Add a
> property "num-banks" to indicate the accurate data.

You have compatible for that. Anyway, your future patch must clearly
explain the problem in details.

Best regards,
Krzysztof