linux-kernel - Re: [PATCH v12 3/39] prctl: arch-agnostic prctl for shadow stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZtbPCcpuXS1M25Xn@arm.com>
Date: Tue, 3 Sep 2024 09:55:37 +0100
From: Yury Khrustalev <yury.khrustalev@....com>
To: Mark Brown <broonie@...nel.org>
CC: <Szabolcs.Nagy@....com>, <akpm@...ux-foundation.org>,
	<aou@...s.berkeley.edu>, <ardb@...nel.org>, <arnd@...db.de>,
	<brauner@...nel.org>, <catalin.marinas@....com>, <corbet@....net>,
	<debug@...osinc.com>, <ebiederm@...ssion.com>, <fweimer@...hat.com>,
	<hjl.tools@...il.com>, <james.morse@....com>, <kees@...nel.org>,
	<kvmarm@...ts.linux.dev>, <linux-arch@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-doc@...r.kernel.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-riscv@...ts.infradead.org>, <maz@...nel.org>, <oleg@...hat.com>,
	<oliver.upton@...ux.dev>, <palmer@...belt.com>, <paul.walmsley@...ive.com>,
	<rick.p.edgecombe@...el.com>, <ross.burton@....com>, <shuah@...nel.org>,
	<suzuki.poulose@....com>, <thiago.bauermann@...aro.org>,
	<wilco.dijkstra@....com>, <will@...nel.org>, <yury.khrustalev@....com>
Subject: Re: [PATCH v12 3/39] prctl: arch-agnostic prctl for shadow stack

On Thu, Aug 29, 2024 at 12:27:19AM +0100, Mark Brown wrote:
> Three architectures (x86, aarch64, riscv) have announced support for
> shadow stacks with fairly similar functionality.  While x86 is using
> arch_prctl() to control the functionality neither arm64 nor riscv uses
> that interface so this patch adds arch-agnostic prctl() support to
> get and set status of shadow stacks and lock the current configuation to
> prevent further changes, with support for turning on and off individual
> subfeatures so applications can limit their exposure to features that
> they do not need.  The features are:
> 
>   - PR_SHADOW_STACK_ENABLE: Tracking and enforcement of shadow stacks,
>     including allocation of a shadow stack if one is not already
>     allocated.
>   - PR_SHADOW_STACK_WRITE: Writes to specific addresses in the shadow
>     stack.
>   - PR_SHADOW_STACK_PUSH: Push additional values onto the shadow stack.
> 
> These features are expected to be inherited by new threads and cleared
> on exec(), unknown features should be rejected for enable but accepted
> for locking (in order to allow for future proofing).
> 
> This is based on a patch originally written by Deepak Gupta but modified
> fairly heavily, support for indirect landing pads is removed, additional
> modes added and the locking interface reworked.  The set status prctl()
> is also reworked to just set flags, if setting/reading the shadow stack
> pointer is required this could be a separate prctl.
> 
> Reviewed-by: Thiago Jung Bauermann <thiago.bauermann@...aro.org>
> Reviewed-by: Catalin Marinas <catalin.marinas@....com>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Acked-by: Yury Khrustalev <yury.khrustalev@....com>