[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb1a6cd0-42aa-4452-9203-460ba768e6a0@gmail.com>
Date: Thu, 5 Sep 2024 15:29:07 +0200
From: Konrad Dybcio <konradybcio@...il.com>
To: Jingyi Wang <quic_jingyw@...cinc.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Conor Dooley <conor@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] soc: qcom: llcc: add errata to get bank num
On 3.09.2024 8:21 AM, Jingyi Wang wrote:
> Use "num-banks" property to indicate the actual num of banks for
> errata.
>
> Signed-off-by: Jingyi Wang <quic_jingyw@...cinc.com>
> ---
> drivers/soc/qcom/llcc-qcom.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 8fa4ffd3a9b5..3fb45e625d82 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -1275,12 +1275,17 @@ static int qcom_llcc_probe(struct platform_device *pdev)
> goto err;
> cfg = &cfgs->llcc_config[cfg_index];
>
> - ret = regmap_read(regmap, cfg->reg_offset[LLCC_COMMON_STATUS0], &num_banks);
> - if (ret)
> - goto err;
> + if (unlikely(!of_property_read_u32(dev->of_node, "num-banks", &num_banks))) {
> + /* errata: get num of llcc banks. */
> + } else {
> + ret = regmap_read(regmap, cfg->reg_offset[LLCC_COMMON_STATUS0], &num_banks);
> + if (ret)
> + goto err;
> +
> + num_banks &= LLCC_LB_CNT_MASK;
> + num_banks >>= LLCC_LB_CNT_SHIFT;
> + }
Is num-banks going to be populated by the bootloader, or hardcoded?
If the latter, we may just do so in the driver, hoping no more SoCs
have this erratum..
Konrad
Powered by blists - more mailing lists